[BUG]: Feed categories collapse when quitting the application with an active search filter

[akinokonomi]

Brief description of the issue

Searching for some feed, and then quitting the RSS Guard without removing the search word will collapse the categories that were filtered out on the next startup.

How to reproduce the bug?

1. Have some categories in feeds list
2. Place "Feeds search box" somewhere in toolbar
3. Type some "word1" which is present in feed name of one of the categories but not in other
4. Hit Ctrl+q
5. Start RSS Guard: all categories except the one with "word1" are collapsed

What was the expected result?

For categories to remain open, if they were.

What actually happened?

Categories collapsed.

Other information

No response

Operating system and version

• OS: Arch Linux
• RSS Guard
  Version: 4.1.0 (built on Linux/x86_64)
  Revision: 8ae0293
  Qt: 5.15.2 (compiled against 5.15.2)

[akinokonomi]

Also, when I enable+disable "Show unread items only" option, every feed category expand.
State of previously collapsed categories does not save.

Is that related, or should be opened as a separate issue?

Likely not related.

[akinokonomi]

when I enable+disable "Show unread items only" option, every feed category expand.

Was fixed with bdc00d5, it was related after all.

Thank you.

[umbellipher]

So how, with bdc00d5, do I now set things so that, on opening and syncing, and syncing later thereafter, all feeds containing unread items are expanded, but those with no unread items remain unexpanded (the way it worked before the latest dev version)?

[martinrotter]

@umbellipher Can you compile list of steps to take to reproduce the situation?

[umbellipher]

@martinrotter

1. Open app with: (a) Feeds -> 'Show unread items only' toggled to show unread items only; Feeds -> 'Automatically expand when selected' ticked; Feeds -> 'Show tree expanders' ticked.
2. Sync, several times.
3. I get what's depicted in Image1.
   

Namely, some unread feeds are expanded, some not.

If I uncheck 'Show tree expanders' and sync again, the unexpanded unread feeds remain unexpanded.

Uncheck, 'Automatically expand...' and resync: same outcome.

Leave 'Automatically expand...' unchecked but tick ''Show tree expanders' and resync: same outcome.

In an ideal world, the app would pick up all unread feeds, whether new (blue) or from a previous sync (black) - as it used to - and expand them upon sync ending.

Does that help?

[akinokonomi]

Show unread items only
In this instance, "items" refer to accounts, categories, and feeds; not just feeds.

Namely, some unread feeds are expanded, some not.

In an ideal world, the app would pick up all unread feeds, whether new (blue) or from a previous sync (black) - as it used to - and expand them upon sync ending.

I think current behaviour is the correct one.

I wouldn't want to see every category that contains unread feeds expand, just because I enabled Show unread items only option.

Just so you know, what RSS Guard actually used to expand were all categories, not some chosen ones.

Uncheck, 'Automatically expand...' and resync: same outcome.

Why would you expect otherwise?
In that case, item (category or account) automatically expands when you select it, and it also works correctly.

Leave 'Automatically expand...' unchecked but tick ''Show tree expanders' and resync: same outcome.

Neither of those options are related to that, so this result is expected.

Ability to have multiple categories goes with idea that only some can be expanded and some collapsed,
But if you always use Show unread only, why can't you just leave all categories expanded?

---

Every fix breaks someone's workflow 😄

But why you call buggy behaviour "ideal world" is still strange to me.