[BUG]: b743c72a crashing intermittently on use of hotkey 'Mark selected item read'

[umbellipher]

Brief description of the issue

As above.

How to reproduce the bug?

1. Set hotkey as necessary.
2. Sync.
3. Select 'unread feeds' only in left pane.
4. Select feed from left pane.
5. Hit hotkey.
6. Move to next feed with 'next unread article' hotkey.

What was the expected result?

Expected result: feed marked as read. Use of 'next unread article' hotkey moves you to next unread feed.

What actually happened?

Sometimes the process happens normally. Sometimes the app freezes and closes. Sometimes use of the 'next unread article' hotkey itself is enough to crash the app.

Other information

I've tried to generate a log, but have so far failed.

Operating system and version

• OS: Windows 10 Pro build 19041
• RSS Guard version: b743c72

[umbellipher]

Oh, and I think 'open in external browser' has stopped working, also.

[martinrotter]

I see, will look into it after holiday.

[martinrotter]

Does it happen with 4.0.4 stable?

[umbellipher]

I think I can clarify further.

The problematic hotkey is 'Mark selected item read (Mark all messages (without message filters) from selected items as read.)'

When this is deployed on a feed with more than one unread post, it functions, marking items as read and moving you on to the next feed with unread item(s). If deployed on a feed with only one unread item, Rssguard crashes.

I hope that may help.

[akinokonomi]

@umbellipher, What hotkeys do you have assigned them to—Next unread article and Mark all messages [...]?

For what it's worth, can't reproduce it by these steps on Arch Linux (b743c72).

[umbellipher]

'INS' and 'PG DN' on Win 10 Pro, respectively - using my daskeyboard numpad, numlock not enabled. These have not changed since first setup, and they worked before the last dev version. I did try to change them so as to go 'CTRL-INS' and 'CTRL-PG DN', but same effect.

[martinrotter]

RN I am AFK, but will check.

[akinokonomi]

Was able to reproduce it.

Steps a bit differ for me.

Conditions

Have an assigned shortcuts or Toolbar actions for:

• Mark item unread
• Next unread article.

Steps

1. Manually mark one article in multiple feeds as unread
2. Enable option "Show unread items only" (default keybinding U)
3. Click some feed just in case, and call Next unread action
4. Now current feed has no unread articles, and we call Mark item unread action
5. Crash

EDIT2: Can reproduce it with c7fb0d2, too, but unable with bd7cb87

EDIT3: (Did not test anything in-between them.)

EDIT4: I put my money on this one 7049e3c though ;)

[umbellipher]

I can expand on this now, with my 'Mark selected item read (Mark all messages (without message filters) from selected items as read.)' version of the issue.

1. It still obtains on the latest dev version, 0d046d6.

2. It's definitely the 'Mark selected item read (Mark all messages (without message filters) from selected items as read.)' hotkey, not the 'Next unread article' one.

3. If I hit the 'Mark selected item...' hotkey when either (a) there is only one unread item in a selected feed; or (b) the bottom unread item in a feed with multiple items is selected and highlighted, then the app crashes.

[martinrotter]

@akinokonomi @umbellipher

OK, I did fix some basic related fuckups I have found: af19e53.

Can you test latest devbuild when it compiles? Also, I've found some related inconsistencies which I will have to tweak.

[umbellipher]

Thank you. Version 4de3db8 now seems to work as concerns my hotkey issue. If others such as @akinokonomi agree, I'm happy to regard this as now closed.

[martinrotter]

Yes, there are some rather minor UI aspects to maybe solve, but if it works, it works right. Let me know @akinokonomi and I can close this.