Include message object with emit#57
Closed
alexwhitman wants to merge 10 commits intomartynsmith:masterfrom
alexwhitman:emit-messages
Closed
Include message object with emit#57alexwhitman wants to merge 10 commits intomartynsmith:masterfrom alexwhitman:emit-messages
alexwhitman wants to merge 10 commits intomartynsmith:masterfrom
alexwhitman:emit-messages
Conversation
Added "err_umodeunknownflag" handler
Owner
|
This looks fine to me, if you could update the documentation too then I'd be happy to pull this. Otherwise I'll try get around to it :-) |
- Also add message to 'kill' emit
…-messages Conflicts: lib/irc.js
Contributor
Author
|
Damnit, looks like I messed something up when re-basing. I'll close this pull request and open a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need access to the message object so I've added it to the emit calls where it makes sense (I ignored whois/chanlist etc where the payload is built up with other messages)