Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

fix(ripple): Provide fallbacks for all custom properties #367

Merged
merged 2 commits into from
Mar 1, 2017
Merged

Conversation

BBosman
Copy link
Contributor

@BBosman BBosman commented Feb 28, 2017

From #361:

  • Ensure all var() lookups have a second parameter
  • Ensure all var() lookups have a fallback of some sort for browsers that don't support custom properties
  • Run material-components-web generated CSS through postcss-custom-properties. Remove any errors and attempt to reduce warnings as much as possible, while taking into account the limitations of the tool.

While running it through postcss-custom-properties I fixed all warnings except for the Custom property ignored: not scoped to the top-level :root element ones.

Passing warnings: false to postcss-custom-properties suppresses that specific warning though, resulting in a warning free build.

Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

@sgomes can we close #361 once this is merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants