Skip to content

Allow to style ::-ms-reveal for the input of md-outlined-text-field #5728

Open

Description

@hviranicitco

Description

Currently we have implemented our own password reveal icon using md-outlined-text-field along with md-icon-button.

Microsoft edge however adds it's own reveal icon as mentioned in https://learn.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal

This is how it looks on edge
image

To remove this , it mentions to add

::-ms-reveal {
    display: none;
}

However, I cannot add this style to the input since the input is within the component

Do we have any way to add this style which I did not realize? If not, can we add this feature to add this style somehow?

Activity

  1. asyncliz commented on Oct 8, 2024

    @asyncliz
    Collaborator

    We can add a display: none style for ::-ms-reveal in this section of text field's styles, where we turn off some other built-in <input> ui elements.

    Do you mind creating a PR to update that?

  2. austinw-fineart commented on Oct 9, 2024

    @austinw-fineart
    Contributor

    Shouldn't that be an optional toggle? Some of us actually prefer using the browser's controls...

  3. asyncliz commented on Oct 9, 2024

    @asyncliz
    Collaborator

    The built-in icon doesn't match Material, and our text field has a spot for Material icons to be added to it.

  4. hamidvirani commented on Oct 10, 2024

    @hamidvirani

    Created a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions