-
Notifications
You must be signed in to change notification settings - Fork 1
Support partial reading of Zarr datasets #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…d reshape them into row vectors
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 96.66% 97.07% +0.40%
==========================================
Files 8 8
Lines 210 239 +29
==========================================
+ Hits 203 232 +29
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@krisfed Please create a test task geck once you are done submitting all of your changes. |
Zarr.m
Outdated
arguments (Output) | ||
newParams (1,:) int64 | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised considering the name of the function, you didn't also use arguments block to validate inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I am doing the basic arguments block validation for Start/Stride/Count in zarrread (better error message and faster erroring out), so not much left to validate here. Not great to validate different things in different places though..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
This is a first draft of allowing partial reads from Zarr datasets.
The proposed interface is as follows (somewhat modeled on
h5read
andncread
):The number of elements in Start/Stride/Count must be the same as the number of dimensions:
Only exception is if the dataset is a vector, in which case scalar Start/Stride/Count are allowed: