Conversation
6d3dae9 to
79faeaf
Compare
|
I don't think we should use cmd for spawning any command, only the bat scripts. So, what needs to happen here I think is a lookup in path, and, if that returns a bat, spawning a cmd. |
|
There are two problems:
That is why I think it's better to always use cmd on Windows. |
We should repeat the exact logic that rust stdlib does here
This shouldn't work, like something like |
|
or, as an alternative, we can invert the logic: look up the command, if it is an exe, run it, otherwise use |
6e0a5a2 to
59d9122
Compare
|
It turned out that the rust stdlib can already run command files correctly via |
Find .cmd or .bat in paths.
|
@matklad, I've rebased the PR on the latest master. |
Fixes #82,
BTW, there are some test failures on Windows (at least on my machine):
this MR does not fix them