Skip to content

Brands renaming#8109

Merged
sanchezzzhak merged 86 commits intomatomo-org:masterfrom
Simbiat:BrandsRenaming
Feb 10, 2026
Merged

Brands renaming#8109
sanchezzzhak merged 86 commits intomatomo-org:masterfrom
Simbiat:BrandsRenaming

Conversation

@Simbiat
Copy link
Copy Markdown
Contributor

@Simbiat Simbiat commented Sep 21, 2025

Description:

Split from #8096 this covers brand name changes, that are mostly more than just addition of a prefix or otherwise more contentious

Review

Comment thread Tests/fixtures/tv-4.yml Outdated
Comment thread Tests/fixtures/feature_phone.yml
Comment thread Tests/fixtures/smartphone.yml
Comment thread Tests/fixtures/tablet-10.yml
@Simbiat
Copy link
Copy Markdown
Contributor Author

Simbiat commented Jan 26, 2026

Fails on composer

dyld[5847]: Library not loaded: @loader_path/../../../../opt/jpeg/lib/libjpeg.9.dylib
  Referenced from: <2E6E9A91-A871-384A-A669-F914E7D3FB65> /opt/homebrew/Cellar/php@7.2/7.2.34_15/bin/php
  Reason: tried: '/opt/homebrew/Cellar/php@7.2/7.2.34_15/bin/../../../../opt/jpeg/lib/libjpeg.9.dylib' (no such file)
/Users/runner/work/_temp/bc4ad433-2388-4fc1-9862-96d78e1273aa.sh: line 1:  5847 Abort trap: 6           composer install

don't think this was caused by me 😅

Comment thread regexes/device/mobiles.yml Outdated
- regex: 'Cherry(?:[ _]?Mobile)?[ _]?([^/;]+)(?: Build|[);])'
model: '$1'

#Previously listed as "White Mobile" brand, but based on https://firmwarefile.com/cherry-mobile-omega-lite-3, https://forum.gsmhosting.com/vbb/f296/cherry-mobile-omega-lite-3-frp-remove-2259709/ and https://deviceatlas.com/device-data/devices/white-mobile/am1010v/30376111 (and others), this is likely "Cherry Mobile", especially since I was not able to find any evidence of "White Mobile" ever existing.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

Cherry Mobile should stay with the old name.
https://www.gadgetpilipinas.net/2016/12/cherry-mobile-defender/

The AM1010V can be separated into a separate brand.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I did not change name for Cherry Mobile. What do you mean?
Are you suggesting we keep White Mobile for AM1010V?

Comment thread regexes/device/mobiles.yml Outdated
Comment thread regexes/device/mobiles.yml Outdated
Comment thread regexes/device/mobiles.yml Outdated
Comment thread regexes/device/mobiles.yml Outdated
Comment thread regexes/device/mobiles.yml Outdated
Comment thread regexes/device/mobiles.yml Outdated
Comment thread regexes/device/mobiles.yml Outdated
Comment thread Parser/Device/AbstractDeviceParser.php Outdated
@sanchezzzhak sanchezzzhak enabled auto-merge (squash) February 10, 2026 06:30
@sanchezzzhak sanchezzzhak merged commit 8bd071c into matomo-org:master Feb 10, 2026
19 checks passed
@Simbiat Simbiat deleted the BrandsRenaming branch February 10, 2026 07:16
Simbiat added a commit to Simbiat/device-detector that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants