Remove incompatibility with mpl v3.x #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mpl v3.x, cbook.is_scalar has been removed. It is used in only one place in basemap, and in that location it is not actually doing anything useful. I made a small reorganization and cleanup in that location in the interp function to fix another bug in which masked locations were being inadvertently unmasked without being filled with the mask value specified in the kwarg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mpl v3.x, cbook.is_scalar has been removed. It is used in only
one place in basemap, and in that location it is not actually doing
anything useful.
I made a small reorganization and cleanup in that location in the
interp function to fix another bug in which masked locations were
being inadvertently unmasked without being filled with the mask
value specified in the kwarg.