Skip to content

Bump text #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2017
Merged

Bump text #8

merged 2 commits into from
Jun 11, 2017

Conversation

Eijebong
Copy link

No description provided.

@matprec
Copy link
Owner

matprec commented Jun 10, 2017

Please ignore travis for now, setup is broken. Reintroduce the version bump and then i'm down for it

@Eijebong
Copy link
Author

It's probably not good anyway... I don't have a mac to test it (kinda hoped travis would help there).

@matprec
Copy link
Owner

matprec commented Jun 11, 2017

Well me neither. Public api changed since then, but our impl should remain untouched. Though i'd like someone to confirm it building on mac.
This and the minor version bump. Then i'm ok with merging

@killercup
Copy link

killercup commented Jun 11, 2017

cargo test works fine on

$ rustc --version --verbose
rustc 1.18.0 (03fc9d622 2017-06-06)
binary: rustc
commit-hash: 03fc9d622e0ea26a3d37f5ab030737fcca6928b9
commit-date: 2017-06-06
host: x86_64-apple-darwin
release: 1.18.0
LLVM version: 3.9

@matprec matprec merged commit 2f2f640 into matprec:master Jun 11, 2017
@Eijebong
Copy link
Author

Nooo don't merge it :o There was still a WIP commit in :/

@matprec
Copy link
Owner

matprec commented Jun 11, 2017

Well seems fine for me? @Eijebong
What needs to be done?

@Eijebong
Copy link
Author

Should've waited for me to remove the WIP commit ^^ I'll send another PR to bump the version when servo people are ready to bump everything at once :)

@matprec
Copy link
Owner

matprec commented Jun 11, 2017

Well did the bump on my own :D we're five minutes in, if you prefer, i'll just rebase on f862919 ? :) @Eijebong

@Eijebong
Copy link
Author

Nah, I guess that's ok

@matprec
Copy link
Owner

matprec commented Jun 11, 2017

If you want to, please open another PR with version bumps. Don't want to steal your credit @Eijebong :)

@Eijebong
Copy link
Author

It's not about credit ^^ It's about not breaking servo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants