-
Notifications
You must be signed in to change notification settings - Fork 19
Bump text #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump text #8
Conversation
Please ignore travis for now, setup is broken. Reintroduce the version bump and then i'm down for it |
It's probably not good anyway... I don't have a mac to test it (kinda hoped travis would help there). |
Well me neither. Public api changed since then, but our impl should remain untouched. Though i'd like someone to confirm it building on mac. |
cargo test works fine on $ rustc --version --verbose
rustc 1.18.0 (03fc9d622 2017-06-06)
binary: rustc
commit-hash: 03fc9d622e0ea26a3d37f5ab030737fcca6928b9
commit-date: 2017-06-06
host: x86_64-apple-darwin
release: 1.18.0
LLVM version: 3.9 |
Nooo don't merge it :o There was still a WIP commit in :/ |
Well seems fine for me? @Eijebong |
Should've waited for me to remove the WIP commit ^^ I'll send another PR to bump the version when servo people are ready to bump everything at once :) |
Nah, I guess that's ok |
If you want to, please open another PR with version bumps. Don't want to steal your credit @Eijebong :) |
It's not about credit ^^ It's about not breaking servo |
No description provided.