Support postgres with SSL requirements #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stupidly just strips any ?sslmode= arguments from the postgres URI and enables SSL without verification regardless of which mode the user specifies.
|
Fixes #24 |
erikjohnston
reviewed
Feb 1, 2021
src/database.rs
Outdated
| let mut client = Client::connect(db_url, postgres::NoTls).unwrap(); | ||
| let mut client : postgres::Client; | ||
|
|
||
| if db_url.contains("sslmode=") { |
There was a problem hiding this comment.
Oh of interest did you try without doing these checks? I have a feeling it Does The Right Thing.
There was a problem hiding this comment.
Don't actually have any non-SSL Postgres cluster to test against at the moment, but my quick perusal of the code seemed to say that it was better to keep it at nossl - though I'm definitely no Rust expert
There was a problem hiding this comment.
I've just tested it and setting the TLS connector works even if TLS is disabled on postgres, so we can get rid of the else statement
There was a problem hiding this comment.
Right, I'll clean up that bit as soon as I have time
|
Thanks for this! Sorry for forgetting about it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently just naively strips any
?sslmode=arguments from the postgres URI and enables SSL without verification, regardless of which mode the user specifies.