Skip to content

Add option to commit changes to the database automatically #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 8, 2021

Conversation

Azrenbeth
Copy link
Contributor

BUILDS ON azren/early_abort_negative_compression

This adds the -c option which commits the changes to the database automatically
(this saves you from having to run it as a seperate command and allows easier testing)

@Azrenbeth Azrenbeth force-pushed the azren/added_commit_option branch from f58090d to a9e9820 Compare August 16, 2021 16:26
@Azrenbeth Azrenbeth marked this pull request as ready for review August 16, 2021 16:28
@Azrenbeth Azrenbeth requested a review from erikjohnston August 16, 2021 16:28
@Azrenbeth Azrenbeth changed the title Azren/added commit option Add option to commit changes to the database automatically Aug 16, 2021
Azrenbeth added 5 commits September 6, 2021 10:15
These will be later to check the commit_changes config option
we need to ensure that the changes don't change what the groups
collapse down to, and also that it leads to the correct structure.
@Azrenbeth Azrenbeth force-pushed the azren/added_commit_option branch from a9e9820 to cf9b202 Compare September 6, 2021 09:16
@erikjohnston erikjohnston self-requested a review September 6, 2021 16:26
@erikjohnston
Copy link
Member

I need to have a closer look at stuff tomorrow, but at a high level looks good

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Azrenbeth Azrenbeth merged commit d908d13 into matrix-org:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants