-
Notifications
You must be signed in to change notification settings - Fork 36
Add option to commit changes to the database automatically #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Azrenbeth
merged 10 commits into
matrix-org:main
from
Azrenbeth:azren/added_commit_option
Sep 8, 2021
Merged
Add option to commit changes to the database automatically #53
Azrenbeth
merged 10 commits into
matrix-org:main
from
Azrenbeth:azren/added_commit_option
Sep 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f58090d
to
a9e9820
Compare
These will be later to check the commit_changes config option we need to ensure that the changes don't change what the groups collapse down to, and also that it leads to the correct structure.
a9e9820
to
cf9b202
Compare
erikjohnston
reviewed
Sep 6, 2021
I need to have a closer look at stuff tomorrow, but at a high level looks good |
erikjohnston
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILDS ON azren/early_abort_negative_compression
This adds the -c option which commits the changes to the database automatically
(this saves you from having to run it as a seperate command and allows easier testing)