Move the graph generation to before early exit #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azrenbeth
force-pushed
the
azren/graphs_before_abort
branch
from
6171ae7 to
8925265
Compare
Azrenbeth
changed the title
Azrenbeth
changed the title
If the tool is making the tables bigger than they were before then the compressor aborts the run. However if you wanted to debug this by looking at before and after graphs of the chunk being compressed then these need to be generated before it aborts
Azrenbeth
force-pushed
the
azren/graphs_before_abort
branch
from
8925265 to
7e9fadb
Compare
erikjohnston
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILDS ON azren/continuing_run
Moved the graph generation to before early exit
If the tool is making the tables bigger than they were before then
the compressor aborts the run. However if you wanted to debug this
by looking at before and after graphs of the chunk being compressed
then these need to be generated before it exits early.