Add method that compresses the chunks with lowest uncompressed state_group ids #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2021 09:29
Query database to retrieve largest uncompressed rooms Go through each one it turn and compress (in chunks) Note: lots of database connections are started and dropped, left as future work to handle keeping connections alive and handling lost connections well.
Previous attempts counted the rows in state_groups_state, but this is slow and unneccessary.
erikjohnston
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #65 which compressed the rooms with the most uncompressed data.
This way won't work on the largest rooms first, so it might take longer to get the same space savings, but it doesn't need to count the number of rows in state_groups_state which would have taken a long time if a room hadn't been compressed before and had a lot of state.