-
Notifications
You must be signed in to change notification settings - Fork 35
add docker files #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker files #83
Conversation
@saces This Dockerfile builds the binary into a different location than is expected by this project:
This commit makes it a bit different than the existing available image here: https://hub.docker.com/r/devture/rust-synapse-compress-state. It did otherwise build properly for me on my arm64 instance! 🥳 I'm going to keep poking around at things to see if I can get things working on my arm64 instance. 😅 Thank you for this PR! |
I was able to adjust the final two COPY commands in this PR and then utilize a locally build arm64 docker image with the Ansible+Docker=Matrix project after overriding this variable. 🎉
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one question
Could a sign-off be added, as per https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off ? |
Signed-off-by: saces <[email protected]>
I assume this question is for @saces as the submitter and not me? I'm happy to add mine if you would like it from reviewers as well. 😅 Signed-off-by: @rlywtf [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-ran my local test build now with these updates. (on an arm64 instance)
> docker build . -t rust-synapse-compress-state | tee -a rust-synapse-compress-state_Dockerfile-build.log
rust-synapse-compress-state_Dockerfile-build.log
That was for @saces, yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
simple alpine based docker container with
synapse_compress_state
andsynapse_auto_compressor
.Example:
My work repos lives here: https://gitlab.com/mb-saces/rust-synapse-compress-state