This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Remove consensus logic from inbound federation. #8025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is "designed" to "handle" the case where the servers view of the state at an event doesn't match what the remote server set as the auth events. With some hand waving the server would try and come to some sort of conclusion of which side was correct, involving state resolution, but this could come up with interesting results. The entire process is unspecced and buggy, so let's just remove it.
|
Not sure of the history, but I think this was done in #12943? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is "designed" to "handle" the case where the servers view of
the state at an event doesn't match what the remote server set as the
auth events. With some hand waving the server would try and come to some
sort of conclusion of which side was correct, involving state
resolution, but this could come up with interesting results.
The entire process is unspecced and buggy, so let's just remove it.
This fixes situations where the server seemingly randomly changed the state of the room, particularly around power levels or join rules.