feat: add gkr unified circuit#305
Open
yoaveshel wants to merge 25 commits into
Open
Conversation
Brings in the full-statement verifier fix (#297) and BabyBear field perf optimisations (#300, plus the BabyBear inverse chain shortening). Pulled changes: - f97cab1 fix: full statement verifier works again (#297) - 4e8d5ef perf(field): shorten BabyBear inverse chain from 40 to 37 ops - a409a0b perf(field): flat-quartic E4 mul/sqr for riscv32 verifier (#300) Conflict resolution: - Code conflicts (Cargo.toml, prover/src/gkr/prover/mod.rs, prover/src/tests/gkr/family_circuits.rs, verifier/tests/corruption.rs, verifier_common/src/lib.rs, verifier_generator/src/gkr/mod.rs): auto-merged cleanly; verified that unified-circuit additions (UnifiedRiscvCircuitOracle, InitsAndTeardownsProduct propagation, corruption-test name suffix + canonicity probe fix) all preserved. - Build break in circuit_defs/{trace_and_split,prover_examples}: the new `inline_inits_and_teardowns: Option<...>` parameter wasn't propagated; added `None` at four call sites. - Generated artifacts (test_proofs/, tools/gkr_verifier/*.{bin,elf,text}): kept ours; will regenerate via gkr_test.sh. - Stale flamegraph SVGs in verifier/: accepted origin's deletion (no longer tracked). Pre-existing workspace errors in legacy STARK crates (circuit_defs/unrolled_circuits/unified_reduced_machine STARK legacy, gpu_witness_eval_generator, tools/pow_config_generator) are inherited from origin/av_gkr_compiler and not on the GKR pipeline path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…_circuit # Conflicts: # prover/test_proofs/add_sub_lui_auipc_mop_sec_80_gkr_proof.json # prover/test_proofs/inits_and_teardowns_sec_80_gkr_proof.json # prover/test_proofs/jump_branch_slt_sec_80_gkr_proof.json # prover/test_proofs/mem_subword_only_sec_80_gkr_proof.json # prover/test_proofs/mem_word_only_sec_80_gkr_proof.json # prover/test_proofs/shift_binop_sec_80_gkr_proof.json # tools/gkr_verifier/add_sub_lui_auipc_mop_sec_80.elf # tools/gkr_verifier/bigint_with_extended_control_sec_80.elf # tools/gkr_verifier/blake2_g_function_sec_80.elf # tools/gkr_verifier/blake2_with_extended_control_sec_80.elf # tools/gkr_verifier/inits_and_teardowns_sec_80.elf # tools/gkr_verifier/jump_branch_slt_sec_80.elf # tools/gkr_verifier/keccak_special5_sec_80.elf # tools/gkr_verifier/mem_subword_only_sec_80.elf # tools/gkr_verifier/mem_word_only_sec_80.elf # tools/gkr_verifier/shift_binop_sec_80.elf # verifier/gkr_flamegraph_add_sub_lui_auipc_mop_sec_80.svg # verifier/gkr_flamegraph_inits_and_teardowns_sec_80.svg # verifier/gkr_flamegraph_jump_branch_slt_sec_80.svg # verifier/gkr_flamegraph_mem_subword_only_sec_80.svg # verifier/gkr_flamegraph_mem_word_only_sec_80.svg # verifier/gkr_flamegraph_shift_binop_sec_80.svg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Is this a breaking change?
Checklist