fix docker push #72
Merged
fix docker push #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
reviewed
Jun 17, 2020
| @@ -71,8 +71,6 @@ jobs: | |||
| push-docker: | |||
| docker: | |||
| - image: circleci/buildpack-deps:stable | |||
There was a problem hiding this comment.
Can we also change this to circleci/golang:1.14 ? This breaks the docker build phase because it doesn't have permissions to /go directory.
There was a problem hiding this comment.
because we were using a path in the executor that point to /go for this build there is nothing related to go build the docker build just download the binary and unpack
There was a problem hiding this comment.
in this new image the /go does not exist, only exist in the golang image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link