Skip to content

Conversation

wenzowski
Copy link
Contributor

next release of graphql has breaking changes
see graphql/graphql-js@d7cc6f9

not ready for merge

@wenzowski
Copy link
Contributor Author

app boots with these changes and appears to work on a quick perusal but the test suite fails on a rethinkdb call I don't have time to track down right now

@mattkrick
Copy link
Owner

nice! let's give it a couple days to hit npm, npm still doesn't treat github repos right (3 years and counting! npm/npm#3081), also it doesn't allow for local caching, which kills if you're installing from a country with less-than-great internet.

@wenzowski
Copy link
Contributor Author

yeah npm + git = 😢
...thus the tarball 😉

graphql actually isn't usable directly from git anyway since @leebyron changes the build dir in his prepublish hook

@mattkrick
Copy link
Owner

wowwww, if anyone wanted to compete with npm, now would definitely be the time for it. npm3 10x slowdown + left-pad + a book of unresolved issues...

@wenzowski
Copy link
Contributor Author

definitely time for gx

@mattkrick
Copy link
Owner

well, at least the name is better than ipfs 😄. looks like it's getting a lil traction in JS land, too: https://github.com/ipmjs/gx-node

this could get interesting...

next release of graphql has breaking changes
see graphql/graphql-js#d7cc6f9aed462588291bc821238650c98ad53580
@wenzowski
Copy link
Contributor Author

rebased and bumped graphql dep to latest

@wenzowski wenzowski changed the title (wip) changes needed for next graphql, closes #130 Update graphql to 0.5.0, closes #130 Apr 18, 2016
@mattkrick
Copy link
Owner

Looks good! Just 1 question... in the spec, the param for authToken is called context. Should context be an object that holds the authToken, or should it be the authToken itself, as it currently is? Basically, this: graphql/graphql-js#326 (comment)

I like how clean it is now, but the context will need to hold other things (for example, in the subscriptions the socket probably belongs in context instead of refs.rootValue since we're literally using the context of the socket & rootValue is more like the surrounding calculations). Thoughts?

@wenzowski
Copy link
Contributor Author

Very good point. I'll look into that, and likely move the socket in too.

@mattkrick mattkrick merged commit d3126b0 into mattkrick:master Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants