Skip to content
This repository was archived by the owner on May 16, 2024. It is now read-only.

Only fail if webpack actually failed to build modules #1

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Only fail if webpack actually failed to build modules #1

merged 1 commit into from
Sep 14, 2016

Conversation

naomiajacobs
Copy link

But still raise if webpack failed to bundle

Do not raise if webpack actually bundles
559947f 
But still raise if webpack failed to bundle
@naomiajacobs
Copy link
Author

@naganowl review please?

naganowl
naganowl approved these changes Sep 14, 2016
View reviewed changes
Copy link

@naganowl naganowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@naomiajacobs naomiajacobs merged commit 2dd3bd0 into master Sep 14, 2016
@naomiajacobs naomiajacobs deleted the module-bundle-failed branch September 14, 2016 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@naganowl naganowl naganowl approved these changes

Assignees

@naganowl naganowl

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naomiajacobs @naganowl