This repository was archived by the owner on May 16, 2024. It is now read-only.
Merge in latest from mipearson/webpack-rails #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for flawless heroku deploy
This allows webpack-rails to be used with non-breaking errors (such as linting).
Only error if manifest error was a module build failure
Change dependency to railties
Prior to this change, webpack-dev-server would also be enabled in environments like staging, which is not something one would expect. This seems like a more sensible default.
Only enable dev server in development & test
Use existing NODE_ENV if available
Fixes SSL certificate verification
Conflicts: lib/webpack/rails/manifest.rb
|
Thanks! Mergin. |
|
@shirish-pampoorickal do we have a branch that tests that this works for us? |
|
Yes, on bigmaven its |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fork has been upgraded to v0.9.10 whereas we are still on v0.9.8. This PR takes care of it