examples: improve params cli tool #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add set_and_verify action that sets a parameter and reads it back to verify the value. Change type detection to use presence of '.' (4 -> int, 4.0 -> float) with fallback to the other type on WrongType. Add clear user feedback about detected types. Refactor set/set_and_verify to share common helper functions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add set_and_verify action that sets a parameter and reads it back to verify the value.
Change type detection to use presence of '.' (4 -> int, 4.0 -> float) with fallback to the other type on WrongType. Add clear user feedback about detected types.
Refactor set/set_and_verify to share common helper functions.