Fix StartTLS #7
Open
Fix StartTLS #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay starting until after the StartTLS handshake as otherwise LDAPConnection.reader() can "steal" reads during the TLS handshake. Also, it's not safe to change l.conn after start() since there is unsynchronized access to l.conn in LDAPConnection.reader(). Since the reader isn't started yet, swap to manually writing the StartTLS request and response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay starting until after the StartTLS handshake as otherwise
LDAPConnection.reader() can "steal" reads during the TLS handshake.
Also, it's not safe to change l.conn after start() since there is
unsynchronized access to l.conn in LDAPConnection.reader().
Since the reader isn't started yet, swap to manually writing the
StartTLS request and response.
I started this fix in 2015 and only yesterday got around to finishing it...