Closed
Description
It doesn't feel like a good practice to use experimental features in a public module.
(node:5859) ExperimentalWarning: The fs.promises API is experimental
When developers are getting that warning it's not easily known how to track it warnings down. It's also not a good practice to encourage developers to use --no-warnings
to just avoid this warning because who knows what other warnings it could be hiding in the future.
This is caused by
// eslint-disable-next-line node/no-unsupported-features/node-builtins
const { createWriteStream, promises: fs } = require('fs')
We're importing const { promisify } = require('util')
a few lines down, could we use that promisify
on the vanilla fs
callback methods, or switch to well-used async wrap modules like make-dir?
I'm an indirect user of this library: I'm getting this warning because a module I use imports a module that imports a module that imports this. 😅 But I'm happy to make a PR.
Metadata
Metadata
Assignees
Labels
No labels