Open
Conversation
Incorporate choojs/nanohtml#32. Technically the `^` makes this not necessary, but @yoshuawuyts suggested that: > cached builds might not catch it so it's recommended to do it anyway
|
So, wouldn’t it be better to replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates choojs/nanohtml#32. Technically the
^makes this not necessary, but @yoshuawuyts suggested that:I didn't bump the
yo-yoversion because I imagine you may have a process for doing that and publishing to npm, but let me know if I should amend the commit to do that.Is it worth also mentioning this new feature in the
README? Feels like we could copy & paste the section frombelthough I'm not sure the history withyo-yoandbel(feels like much of the docs could be copied & pasted) so I won't presume.