Bug: CultureInfo isn't passed when parsing

[bkoelman]

StringTypeConverterBase<> does not pass along the incoming culture to its abstract Parse method. It should, and derived types should pass it along to the DateOnly.Parse and TimeOnly.Parse methods.

Because of the current behavior, properties such as RangeAttribute.ConvertValueInInvariantCulture and RangeAttribute.ParseLimitsInInvariantCulture have no effect when using ASP.NET ModelState binding/validation. The parsing happens in the "current" culture, which is the OS-level regional settings of the web server that the application is running on. It should be possible to avoid that by parsing using the invariant culture. That way, the web application can be deployed to servers all over the world and behave the same.

[bkoelman]

For reference, see: https://github.com/dotnet/runtime/blob/main/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/DateOnlyConverter.cs#L48

[maxkoshevoi]

Thanks for filing this! I'll look into this over the coming week, or you can create a PR if you'd like

[bkoelman]

Thanks for the offer, but I have too many things going on right now to create a PR. There's no urgency from my side to get this fixed, so if you can look into it somewhere next week, that would be great.

[maxkoshevoi]

Hm, okay, there's type converter and json converter. If I change type converter to respect provided culture, they would behave differently. And it seems like json converter from the runtime does use invariant culture:
https://github.com/dotnet/runtime/blob/4af855b0101bad16a4e25a7ec3c4c6a2f2984fb0/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateOnlyConverter.cs#L61

Do you have some context on why are they implemented differently? This way if DateOnly is passed as a query argument - current culture will be used, and if it's passed in the request's body - it wouldn't be. Or maybe I'm missing something

Here're some draft changes so far: https://github.com/maxkoshevoi/DateOnlyTimeOnly.AspNet/compare/16-culture?expand=1

[bkoelman]

They are supposed to behave differently. JSON prescibes how numbers and dates are formatted, irrespective of culture. TypeConver is typically used to bind objects to UI controls, where using the current culture by default makes sense. To make TypeConverter not use the current culture (ie when parsing a query string), feed it a fixed culture, such as invariant.

[maxkoshevoi]

Could you try v2.1.1, and see if it resolved the issue?

[bkoelman]

Yes, that solves the problem. Thanks for the fix!