feat/chore: ETT: UI changes for expansion beyond Outfront screens#711
Merged
feat/chore: ETT: UI changes for expansion beyond Outfront screens#711
Conversation
deanshi
changed the title
digitalcora
approved these changes
Apr 9, 2026
| @@ -131,7 +131,6 @@ class OutfrontTakeoverTool extends React.Component< | |||
| <div className="app-title"> | |||
| <img src="/images/t-identity.png" alt="Logo" className="logo" /> | |||
| <div className="stacked-title text-30"> | |||
| <div>Outfront Media screens</div> | |||
Contributor
There was a problem hiding this comment.
nit: some simplification of the markup/classes may be possible here now that this no longer needs to be a "stacked-title". (Alternatively perhaps we could keep the stacking but just change the wording to something else that fits the new scope of the tool. "In-station screens"? "Real-time info screens"?)
Contributor
Author
There was a problem hiding this comment.
I do like the alternative text. Going to add Real-time Info Screens, since the extra context doesn't hurt and we have the space.
- Replaced and removed text in a few places referencing Outfront - Removed ScreenIcon, references and scss associated with it - Typescript files for Outfront renamed to Emergency - Elixir files for Outfront renamed to Emergency - kept the Outfront specific folder for fake_sftp_client, sftp and ssh_key_provider - also moved a background color in CSS for Emergency Takeover screen
deanshi
force-pushed
the
deanshi/ett-expand-outfront
branch
from
d842381 to
5151ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: ETT: UI changes for expansion beyond Outfront screens
Description
The few places I didn't change the Outfront name include:
outfront_takeover_tool.mdoutfront_takeover_tool_screens.exslist of screensMy thought here is that some of these descriptions/images can be updated as we're actually adding the new functionality, but if we want to preemptively remove them I can do that as well.