fix parsing of messages with no zones#1625
Merged
panentheos merged 1 commit intomasterfrom Apr 17, 2026
Merged
Conversation
digitalcora
approved these changes
Apr 17, 2026
| zone -> | ||
| {String.split(zone, "-") |> List.first(), | ||
| MapSet.new(zones, &(String.split(&1, "-") |> List.last()))} | ||
| end |
Contributor
There was a problem hiding this comment.
My clever-pattern-matching neuron is activating:
defp decode_zones([]), do: {nil, MapSet.new()}
defp decode_zones([first | _] = zones) do
# ...
endOpinions on whether this is more readable may vary.
Collaborator
Author
There was a problem hiding this comment.
Definitely would have done that, but the parameter is a MapSet, which is less amenable to matching.
Contributor
There was a problem hiding this comment.
Ohhhhhh. I guess I assumed it was a list since you were explicitly picking out the "first" item, not realizing this was just a way to pick a single arbitrary item out of a set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This fixes a parsing error when receiving messages with an empty zone list, which happens sometimes because of some sign configs. After the message is parsed this way, the downstream logic will correctly end up treating it as a no-op.