fix: Moved "Return to Regular Route" into root directions list#2521
Merged
hannahpurcell merged 11 commits intomainfrom Mar 29, 2024
Merged
fix: Moved "Return to Regular Route" into root directions list#2521hannahpurcell merged 11 commits intomainfrom
hannahpurcell merged 11 commits intomainfrom
Conversation
hannahpurcell
changed the title
firestack
reviewed
Mar 26, 2024
firestack
reviewed
Mar 26, 2024
Coverage of commit
|
Coverage of commit
|
Coverage of commit
|
firestack
reviewed
Mar 28, 2024
firestack
reviewed
Mar 28, 2024
firestack
previously approved these changes
Mar 28, 2024
Contributor
firestack
left a comment
firestack
left a comment
There was a problem hiding this comment.
Two comments but otherwise this looks good!
firestack
dismissed
their stale review
didn't mean to approve just yet 😬 and I would like those comments resolved before merging
joshlarson
reviewed
Mar 28, 2024
Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
Contributor
|
I think it looks good - I made a few non-blocking nits, but the only reason I'm not approving is so that I don't scoop Kayla's review. |
Coverage of commit
|
Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
Co-authored-by: Josh Larson <jlarson@mbta.com>
firestack
approved these changes
Mar 28, 2024
Contributor
firestack
left a comment
firestack
left a comment
There was a problem hiding this comment.
LGTM, Thanks @hannahpurcell!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The little things I like about this approach is that
diversionPagenow sufficiently covers the check "was 'Return to Regular Route' added to the directions sequence"Also included, updating the Storybook story for this!