Prevent summary comment closure note being posted multiple times#1241
Merged
Prevent summary comment closure note being posted multiple times#1241
Conversation
The filtering of open threads only treated a thread as closed if it wasn't a summary comment, so reposted the notice about a thread needing manually resolved on each execution of the decorator. The filtering of comments has therefore been changed to only consider whether a thread is resolved or has the manual resolution comment on it, without considering whether the thread is for a summary comment.
mc1arke
force-pushed
the
summary-note-close
branch
from
48d8bb0 to
56b8ac5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filtering of open threads only treated a thread as closed if it wasn't a summary comment, so reposted the notice about a thread needing manually resolved on each execution of the decorator. The filtering of comments has therefore been changed to only consider whether a thread is resolved or has the manual resolution comment on it, without considering whether the thread is for a summary comment.