Skip to content

Add py.typed, run type checks as part of GitHub Actions#31

Merged
mdickinson merged 6 commits into
mainfrom
type-checking
May 17, 2025
Merged

Add py.typed, run type checks as part of GitHub Actions#31
mdickinson merged 6 commits into
mainfrom
type-checking

Conversation

@mdickinson
Copy link
Copy Markdown
Owner

@mdickinson mdickinson commented May 17, 2025

This PR:

  • adds the missing py.typed marker file that indicates to consumers that the code has usable type hints
  • moves type checks to the test job of on-commit GitHub Actions workflow, instead of the style job. (Those type checks are Python-version dependent, and we want our type hints to be valid for all supported Python versions.)
  • fixes type hints to be Python 3.8-compatible on the fraction_to_float.py script

Note: we're hitting a (known, fixed in main) issue with mypy and Python 3.14, so we skip the type check on Python 3.14 for now. xref: python/mypy#19020

@mdickinson mdickinson merged commit b11ee46 into main May 17, 2025
7 checks passed
@mdickinson mdickinson deleted the type-checking branch May 17, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant