Skip to content

Silence linter complaints about importing a private function #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 1 commit into from
Nov 2, 2025
Merged

Silence linter complaints about importing a private function #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/simplefractions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
import numbers
import typing

from simplefractions._simplest_in_interval import _simplest_in_interval
from simplefractions._simplest_in_interval import simplest_in_interval_strict

#: Names to be exported when doing 'from simplefractions import *'.
__all__ = ["simplest_from_float", "simplest_in_interval"]
Expand Down Expand Up @@ -103,8 +103,11 @@ def simplest_in_interval(
if right is not None:
right = fractions.Fraction(right)

return _simplest_in_interval(
left, right, include_left=include_left, include_right=include_right
return simplest_in_interval_strict(
left,
right,
include_left=include_left,
include_right=include_right,
)


Expand Down Expand Up @@ -173,4 +176,9 @@ def simplest_from_float(x: float) -> fractions.Fraction:
raise ValueError("x should be finite")

left, right, closed = _interval_rounding_to(x)
return _simplest_in_interval(left, right, include_left=closed, include_right=closed)
return simplest_in_interval_strict(
left,
right,
include_left=closed,
include_right=closed,
)
4 changes: 3 additions & 1 deletion src/simplefractions/_simplest_in_interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _simplest_in_interval_pos(
return a + b, c + d


def _simplest_in_interval(
def simplest_in_interval_strict(
left: fractions.Fraction | None = None,
right: fractions.Fraction | None = None,
*,
Expand All @@ -155,6 +155,8 @@ def _simplest_in_interval(
"""
Simplest fraction in a subinterval of the real line.

Strictly-typed version: both left and right must be fractions.Fraction instances.

Parameters
----------
left : fractions.Fraction, optional
Expand Down