Remove suggestion that order of table elements isn't important #32909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallonbacka
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:Learn:HTML
|
Preview URLs (comment last updated: 2024-04-02 07:12:43) |
chrisdavidmills
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Hi there @Mallonbacka, and thanks so much for your contribution to MDN! I totally agree with the motivation for making this change, and I think your suggestions work well. I've just got one wording suggestion for you to consider, after which we can get it merged.
ferdnyc
reviewed
Apr 2, 2024
github-actions
bot
added
size/s
Remove suggestion that order of table elements isn't important, and consistently refer to them, in this section, in the order they are used.
Mallonbacka
force-pushed
the
32798-table-order
branch
from
2b5fba8 to
fade1bd
Compare
chrisdavidmills
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
This is looking great, thanks @Mallonbacka! I just made one tiny change, and now I think we are ready to merge.
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in the related issue, the suggestion that
<thead>,<tfoot>and<tbody>can be given in any order as children of a<table>deviates from the HTML spec, and causes the presentation to screen reader users to deviate from the visual structure, at least on one browser/AT combination.Motivation
While it makes no difference most of the time, there is a case where this practice can be observed causing problems for a small set of assistive technology users. Since the practice deviates from the HTML spec, this also ensures that what MDN recommends to readers follows the specification.
I also found line 72 unclear, as it seemed to conflict with the prior content on line 71 - if the body can appear below the footer, how does the footer always appear at the bottom? I've removed the unclear part, so that the order (according to the specification) is unambiguous -
<thead>,<tbody>,<tfoot>.Additional details
<table>in the HTML standard, with the relevant section highlightedRelated issues and pull requests
Fixes #32798