Technical review: Document the ToggleEvent.source property #40533
+100
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
sideshowbarker
and removed request for
a team
chrisdavidmills
changed the title
|
Can I get a tech review, please, @josepharhar? I'm on vacation for a week next week, so there might be a bit of a delay getting it merged. |
josepharhar
reviewed
Jul 25, 2025
| @@ -29,6 +29,8 @@ _This interface inherits properties from its parent, {{DOMxRef("Event")}}._ | |||
| - : A string (either `"open"` or `"closed"`), representing the state the element is transitioning to. | |||
| - {{DOMxRef("ToggleEvent.oldState")}} {{ReadOnlyInline}} | |||
| - : A string (either `"open"` or `"closed"`), representing the state the element is transitioning from. | |||
| - {{DOMxRef("ToggleEvent.source")}} {{Experimental_Inline}} {{ReadOnlyInline}} | |||
| - : An {{domxref("Element")}} object instance representing the HTML control that initiated the toggle. | |||
There was a problem hiding this comment.
ToggleEvent.source may be null, for example if you just call popover.showPopover() from script. Not sure if this is worth mentioning here.
|
|
||
| The **`source`** read-only property of the {{domxref("ToggleEvent")}} interface is an {{domxref("Element")}} object instance representing the HTML popover control element that initiated the toggle. | ||
|
|
||
| A {{htmlelement("button")}} or `<input type="button">` element can be specified as a popover control by specifying the [`id`](/en-US/docs/Web/HTML/Reference/Global_attributes/id) of the popover element in its [`commandfor`](/en-US/docs/Web/HTML/Reference/Elements/button#commandfor) or [`popovertarget`](/en-US/docs/Web/HTML/Reference/Elements/button#popovertarget) attribute. |
There was a problem hiding this comment.
I don't think command attribute work on <input type=button>?
|
|
||
| ## Value | ||
|
|
||
| An {{domxref("Element")}} object instance, or `null` if the popover does not have a control element (for example, if the popover is being controlled using a JavaScript method such as {{domxref("HTMLElement.togglePopover()")}}). |
There was a problem hiding this comment.
Instead of saying "if the popover does not have a control element" id say "if the popover was not triggered (or activated?) by a control element"
In this example, the popover does have a control element but the ToggleEvent fired will have a null source:
<button commandfor=popover command=show-popover>control</button>
<div id=popover popover=auto>popover</div>
<script>
popover.showPopover();
</script>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome 140 adds support for the
ToggleEvent.sourceproperty. See #39723 for details.This PR adds documentation for the new property.
Motivation
Additional details
Related issues and pull requests
Fixes #39723.