Skip to content

Update core-js data #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Update core-js data #9119

merged 1 commit into from
Oct 15, 2021

Conversation

zloirock
Copy link
Contributor

No description provided.

@zloirock zloirock requested a review from a team as a code owner September 20, 2021 20:08
@zloirock zloirock requested review from Rumyra and removed request for a team September 20, 2021 20:08
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/RegExp
Title: RegExp() constructor
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/sort
Title: TypedArray.prototype.sort()
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp
Title: RegExp
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/RegExp
Title: RegExp() constructor
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/dotAll
Title: RegExp.prototype.dotAll
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
Title: Array.prototype.sort()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/at
Title: String.prototype.at()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr
Title: String.prototype.substr()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
Title: Object.hasOwn()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/unescape
Title: unescape()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/sort
Title: TypedArray.prototype.sort()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getYear
Title: Date.prototype.getYear()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toGMTString
Title: Date.prototype.toGMTString()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setYear
Title: Date.prototype.setYear()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/escape
Title: escape()
on GitHub

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

We have a project in planning to improve the way we provide polyfills on MDN. I think it might be best to hold off on changes like this until we have a better idea of how we want to do it.

@Elchi3 , @ddbeck , @Rumyra , @teoli2003 ...?

@zloirock
Copy link
Contributor Author

zloirock commented Sep 22, 2021

core-js data was added already after creating of this discussion. Anyway, it's better to update it for consistency with hundreds of other pages.

core-js is the most comprehensive and the most popular polyfill project and is used in most popular internet sites, so I don't think that makes sense to avoid core-js results in favor of something else, that, sure, also could be added.

@wbamberg
Copy link
Collaborator

core-js data was added already after creating of this discussion. Anyway, it's better to update it for consistency with hundreds of other pages.

Fair enough. I didn't know this conversation had already happened.

@zloirock
Copy link
Contributor Author

@Rumyra

@Rumyra Rumyra merged commit 5e90bae into mdn:main Oct 15, 2021
@Rumyra
Copy link
Collaborator

Rumyra commented Oct 15, 2021

Thanks for the mention @zloirock

@zloirock zloirock deleted the update-core-js-data branch October 15, 2021 16:09
@zloirock zloirock mentioned this pull request Dec 24, 2021
@zloirock zloirock mentioned this pull request Feb 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants