Skip to content

addEventListener resides on the protototype #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

addEventListener resides on the protototype #9614

wants to merge 1 commit into from

Conversation

franktopel
Copy link

Summary

addEventListener resides on the protototype property of EventTarget, not on the constructor function itself.

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@franktopel franktopel requested a review from a team as a code owner October 6, 2021 11:10
@franktopel franktopel requested review from jpmedley and removed request for a team October 6, 2021 11:10
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 6, 2021
@jpmedley
Copy link
Collaborator

jpmedley commented Oct 6, 2021

@ddbeck Does this follow current practice?

@wbamberg
Copy link
Collaborator

wbamberg commented Oct 7, 2021

This is another manifestation of https://github.com/mdn/content/discussions/5121, which did (amazingly) reach a resolution: https://github.com/mdn/content/discussions/5121#discussioncomment-785747 and is I think just waiting for someone to do it.

It proposed as a Q4 2021 Open Web Docs project (openwebdocs/project#55) but got ranked 9, meaning that the OWD team probably won't get to it in Q4. We might get to it in the next quarter, depending how the voting goes. Or it will need a driver from somewhere else (I think there's a fairly small amount of coordination/tracking work, and quite a lot of pretty automatic/mundane work to make the actual updates).

In the meantime I think we should close this PR and the other two.

@wbamberg wbamberg closed this Oct 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants