fix(sidebar): avoid empty span #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
avoid-empty-span
branch
from
4d95fb3 to
4eab947
Compare
|
I think we should ask whether to change this in the cssref sidebar: It's currently: - type: section
link: /Web/CSS/Layout_cookbook
- children:
- /Web/CSS/Layout_cookbook/Media_objects
- /Web/CSS/Layout_cookbook/Column_layouts
- /Web/CSS/Layout_cookbook/Center_an_element
- /Web/CSS/Layout_cookbook/Sticky_footers
- ...But maybe we want: - type: section
link: /Web/CSS/Layout_cookbook
children:
- /Web/CSS/Layout_cookbook/Media_objects
- /Web/CSS/Layout_cookbook/Column_layouts
- /Web/CSS/Layout_cookbook/Center_an_element
- /Web/CSS/Layout_cookbook/Sticky_footers
- ...Anyhow there's use cases for having children without title so let's fix this. I just refactored it a tiny bit. |
fiji-flo
approved these changes
Jun 18, 2025
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids empty spans in the sidebar.
Motivation
Noticed empty
<span></span>on https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook (in the<li>following theLayout cookbooklink in the sidebar), after adding padding in mdn/fred@6befb4f.Additional details
Visually noticable here: https://fred.review.mdn.allizom.net/en-US/docs/Web/CSS/Layout_cookbook
Related issues and pull requests