[Issue#115] : add onboarding page when extension is first installed#129
Merged
mdolr merged 10 commits intomdolr:masterfrom Oct 17, 2020
Merged
[Issue#115] : add onboarding page when extension is first installed#129mdolr merged 10 commits intomdolr:masterfrom
mdolr merged 10 commits intomdolr:masterfrom
Conversation
Owner
|
Thank you for your PR I've changed some things, trying to make the onboarding page look like the popup. Also I removed the "enable on survol on this page" parameter as it doesn't make any sense here. I'm unsure about the gif idea honestly. I think we should use something else. Also maybe we could add a way to show the changelog using the Git releases feed ? |
Contributor
Author
Let me know if you have other thoughts around, I can remove the gif. I kind of looks gigantic now. I'll look at the git releases feed |
Contributor
Author
Contributor
Author
Owner
|
Great changes, I'm waiting for #131 which adds a new setting and then I'll be able to merge this |
mdolr
approved these changes
Oct 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is part of issue#115
Changes made:
bootsrap.jsto have common functionalities which can used by both popup and onboardingThings to further improve (This could be on a separate PR) :
bootstrap.jsEnable Survol on this pagefrom onboarding page ✅