Skip to content

Conversation

vasconsaurus
Copy link
Contributor

Description

Originally from a Dependabot alert:

Impact
The REXML gem before 3.3.1 has some DoS vulnerabilities when it parses
an XML that has many specific characters such as <, 0 and %>.

If you need to parse untrusted XMLs, you may be impacted to these vulnerabilities.

Patches
The REXML gem 3.3.2 or later include the patches to fix these vulnerabilities.

References

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Impact
The REXML gem before 3.3.1 has some DoS vulnerabilities when it parses
an XML that has many specific characters such as <, 0 and %>.

If you need to parse untrusted XMLs, you may be impacted to these vulnerabilities.

Patches
The REXML gem 3.3.2 or later include the patches to fix these vulnerabilities.

References
 - GHSA-vg3r-rm7w-2xgh : This is a similar vulnerability
 - https://www.ruby-lang.org/en/news/2024/07/16/dos-rexml-cve-2024-39908/
@vasconsaurus vasconsaurus marked this pull request as ready for review August 2, 2024 11:01
@vasconsaurus vasconsaurus merged commit 4ef92f3 into develop Aug 2, 2024
4 checks passed
@vasconsaurus vasconsaurus deleted the 4956-dependabot-alert-REXML-denial-service branch August 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants