Skip to content

Add automatic minor increase on feature #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jun 15, 2021

When a new feature is added to a project that already has a fist major version, the update of the semver goes the following way:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards compatible manner, and
PATCH version when you make backwards compatible bug fixes.

This does not apply on packages with no major version.

To avoid having to manually update the minor version on new features, this PR adds the automation of the minor increase when using the new-feature label.

Naming of the label

feature 👍

The name feature is based on the following common practices:
GitHub Labels that are logical, colorful and sensible
GitLab suggested labels

Categorize epics, issues, and merge requests using colors and descriptive titles like bug, feature request, or docs.

Take into account that these are two suggested naming. A lot of other articles exists with different suggestion and the first article also invites to use type: in front of the label.

new-feature 🎉

Another possibility would be to use new-feature as it is more explicit linked to a PR and not an issue.

I suggest new-feature instead of new feature for consistency with breaking-changes and skip-changelog

If you prefer feature 👍
If you prefer new-feature 🎉

⚠️ Wait for this pr before merging

@bidoubiwa bidoubiwa marked this pull request as draft June 15, 2021 10:07
@bidoubiwa bidoubiwa requested a review from curquiza June 15, 2021 10:07
@bidoubiwa bidoubiwa marked this pull request as ready for review June 15, 2021 10:08
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 15, 2021
@bidoubiwa bidoubiwa requested a review from mdubus June 15, 2021 10:20
@bidoubiwa bidoubiwa requested a review from curquiza June 15, 2021 10:21
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks!
I've just added the new-feature label to this repository! :)

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 15, 2021

Build succeeded:

@bors bors bot merged commit 30c37aa into main Jun 15, 2021
@bors bors bot deleted the automatic_minor_new_feature branch June 15, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants