-
Notifications
You must be signed in to change notification settings - Fork 30
Add automatic minor increase on feature #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
requested changes
Jun 15, 2021
Co-authored-by: Clémentine Urquizar <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>
…isearch/docs-searchbar.js into automatic_minor_new_feature
curquiza
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! thanks!
I've just added the new-feature
label to this repository! :)
mdubus
approved these changes
Jun 15, 2021
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new feature is added to a project that already has a fist major version, the update of the semver goes the following way:
This does not apply on packages with no major version.
To avoid having to manually update the minor version on new features, this PR adds the automation of the minor increase when using the
new-feature
label.Naming of the label
feature 👍
The name
feature
is based on the following common practices:GitHub Labels that are logical, colorful and sensible
GitLab suggested labels
Take into account that these are two suggested naming. A lot of other articles exists with different suggestion and the first article also invites to use
type:
in front of the label.new-feature 🎉
Another possibility would be to use
new-feature
as it is more explicit linked to a PR and not an issue.I suggest
new-feature
instead ofnew feature
for consistency withbreaking-changes
andskip-changelog
If you prefer
feature
👍If you prefer
new-feature
🎉