-
Notifications
You must be signed in to change notification settings - Fork 264
v0.28: Changes to /documents
#1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/documents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the spec, the fields
parameter is now also available for the GET /indexes/:uid/documents/:document_uid
route.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🦋
A few suggestions:
- Update
learn/getting_started/algolia_migration.md
line 193:displayedAttributes
setting does not impact the displayed fields returned - I think we should update the
get_documents_1
code sample to show how to use thefields
parameter - Add a note that
fields
values are case-sensitive.
@maryamsulemani97: thanks for the suggestions. I agree with the second and third, but unless I'm mistaken the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘
Two rows use |
@maryamsulemani97: hmmmm…I'm not sure why it's there two times—could be an error, or that Algolia does not distinguish between things we do (and thus need two separate names). In any case, the line introducing the table reads (emphasis mine):
It explicitly states that this concerns settings and search parameters while So I still think that, since the table is about index settings and search parameters, it should not be affected by changes to the /documents route. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥷
bors merge |
Build succeeded: |
Closes #1700