Skip to content

V0.29: update api keys to add * action #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2022
Merged

V0.29: update api keys to add * action #1863

merged 5 commits into from
Sep 29, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1839

@maryamsulemani97 maryamsulemani97 added this to the v0.29 milestone Sep 6, 2022
curquiza
curquiza reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add something we do not recommend creating keys that can perform every actions, it's almost an equivalent to the master key? WDYT?

curquiza
curquiza reviewed Sep 6, 2022
View reviewed changes
maryamsulemani97
maryamsulemani97 commented Sep 6, 2022
View reviewed changes
@guimachiavelli guimachiavelli self-assigned this Sep 7, 2022
guimachiavelli
guimachiavelli requested changes Sep 7, 2022
View reviewed changes
@maryamsulemani97 maryamsulemani97 removed their assignment Sep 8, 2022
guimachiavelli
guimachiavelli approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐤

@guimachiavelli guimachiavelli linked an issue Sep 28, 2022 that may be closed by this pull request
v0.29: Update API keys to add * action #1839
Closed
@guimachiavelli
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

Build succeeded:

@bors bors bot merged commit b7817d3 into v0.29 Sep 29, 2022
@bors bors bot deleted the v0.29--Update-API-keys-to-add---action branch September 29, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@curquiza curquiza Awaiting requested review from curquiza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.29
Development

Successfully merging this pull request may close these issues.

v0.29: Update API keys to add * action
3 participants
@maryamsulemani97 @guimachiavelli @curquiza