Skip to content

V0.29: updates to auto-batching #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 29, 2022
Merged

V0.29: updates to auto-batching #1864

merged 14 commits into from
Sep 29, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1838

@maryamsulemani97 maryamsulemani97 added this to the v0.29 milestone Sep 6, 2022
@maryamsulemani97 maryamsulemani97 changed the base branch from master to v0.29 September 6, 2022 10:11
maryamsulemani97
maryamsulemani97 commented Sep 7, 2022
View reviewed changes
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review September 7, 2022 07:29
Kerollmops
Kerollmops requested changes Sep 7, 2022
View reviewed changes
Kerollmops
Kerollmops approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change, LGTM!
bors merge

@bors
Copy link
Contributor

bors bot commented Sep 8, 2022

🔒 Permission denied

Existing reviewers: click here to make Kerollmops a reviewer

@Kerollmops
Copy link
Member

Kerollmops commented Sep 8, 2022 •
edited
Loading

Oooopsss! Bad habits...
bors cancel

dichotommy
dichotommy previously requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good to me 🎉

Could you add a redirect for the deleted autobatching page in case there were any external links to it? Don't worry about the experimental section overview, since it may be added back in the future.

guimachiavelli
guimachiavelli reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, most of them very low priority and subjective since we have time to spare right now.

guimachiavelli
guimachiavelli requested changes Sep 19, 2022
View reviewed changes
maryamsulemani97
maryamsulemani97 commented Sep 19, 2022
View reviewed changes
guimachiavelli
guimachiavelli approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📳

@guimachiavelli guimachiavelli dismissed dichotommy’s stale review September 29, 2022 13:43

reviewed and approved by another docs team member

@guimachiavelli
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

Build succeeded:

@bors bors bot merged commit 4a20895 into v0.29 Sep 29, 2022
@bors bors bot deleted the v0.29--Updates-to-auto-batching branch September 29, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@Kerollmops Kerollmops Kerollmops approved these changes

@dichotommy dichotommy Awaiting requested review from dichotommy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.29
Development

Successfully merging this pull request may close these issues.

v0.29: Updates to auto-batching
4 participants
@maryamsulemani97 @Kerollmops @guimachiavelli @dichotommy