Skip to content

v0.29: filter updates #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 29, 2022
Merged

v0.29: filter updates #1869

merged 8 commits into from
Sep 29, 2022

Conversation

guimachiavelli
Copy link
Member

@guimachiavelli guimachiavelli commented Sep 7, 2022

Closes #1853

@guimachiavelli guimachiavelli changed the base branch from master to v0.29 September 7, 2022 14:56
@guimachiavelli guimachiavelli added this to the v0.29 milestone Sep 7, 2022
@guimachiavelli guimachiavelli marked this pull request as ready for review September 8, 2022 11:27
Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link

@loiclec loiclec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-) I had some minor nitpicks but I think it is well explained!

Copy link

@loiclec loiclec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect 👍 thanks :-)

Copy link
Contributor

@maryamsulemani97 maryamsulemani97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since we have time, do you think we should restructure the "Filter expressions" section?
  • Instead of listing each operator as a bullet, we could convert it to a sub-heading with an example, like Loïc has done in the spec. It will make it a lot easier to explain each filter and it looks a lot more organised
  1. We should update the example (/learn/advanced/filtering_and_faceted_search.html#example-2) to add the EXISTS and IN operators

@guimachiavelli
Copy link
Member Author

Thanks for the feedback, @maryamsulemani97—as we discussed over slack, your suggestions are great but the current structure for the operators doesn't really support adding exhaustive information. We will review the whole filters guide soon (#1902) and keep the current version, warts and all, for the release.

Copy link
Contributor

@maryamsulemani97 maryamsulemani97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛸

@guimachiavelli
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2022

@bors bors bot merged commit 83ebdfb into v0.29 Sep 29, 2022
@bors bors bot deleted the v0.29-filter-updates branch September 29, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.29: Updates to the filter search parameter
4 participants