-
Notifications
You must be signed in to change notification settings - Fork 264
Removelearn/configuration/settings.md
#2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the addition of the developer-friendly syntax to the settings API reference. I think it adds a lot in terms of drawing the reader's eye.
Co-authored-by: Tommy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧘🏻
bors merge |
Build succeeded: |
closes #1614
Update
What is this PR doing?
/learn/configuration/settings.md
to API reference/learn/configuration/settings.md
- Moves "developer-friendly syntax"(displayedAttributes=[<String>, <String>, ...]
) to a new column "Format" in the table in/learn/configuration/settings.md
- I don't like how the table looks because of the "Format" column, and "Type" and "Format" are talking about the same thing:- Should we remove "Type"? I think it's a lot easier to process compared to "Format"- Orrr we could have the same table as the API reference? It will be easier to update too. Update one table and copy it to the otherWDYT @guimachiavelli @dichotommy?/learn/configuration/settings.md
/learn/configuration/instance_options.md
under Configuration. Move the guides to "Advanced topics"/learn/configuration/settings.md