Add code samples for sorting/filtering nested fields #2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oluademola
previously approved these changes
Dec 22, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Dec 22, 2022
2050: Add code samples for sorting/filtering nested fields r=maryamsulemani97 a=guimachiavelli Closes #2035 Code samples are currently in code blocks to **_ease_** reviewing, but will be moved to `.code-samples.meilisearch.yaml` and `sample-template.yaml` after approval. Co-authored-by: gui machiavelli <[email protected]>
|
bors r- |
|
Canceled. |
guimachiavelli
dismissed stale reviews from oluademola and maryamsulemani97
via
8f77710
maryamsulemani97
suggested changes
Dec 22, 2022
|
Build succeeded: |
This was referenced Feb 22, 2023
Merged
bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
2061: review filtering guide r=maryamsulemani97 a=maryamsulemani97 closes #1902, #860, #837, and #1850 - moves all operators to a new heading - removes SQL syntax and combines it with the curl code samples - replaces amazon and imdb images for facets with meilisearch demo images - removes unused images in `.vuepress/public/faceted-search` - remove redundant code samples <hr> - Improve coherence between dataset and examples - A sample document was added as part of #2050 with `rating` and `director` fields - This PR uses `movie_ratings` instead of `movies` to clarify that this is a separate dataset - `faceted_search_facets_1` still uses `movies` as this code sample is used in the API reference as well Co-authored-by: Maryam Sulemani <[email protected]> Co-authored-by: Maryam <[email protected]> Co-authored-by: maryamsulemani97 <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
2061: review filtering guide r=maryamsulemani97 a=maryamsulemani97 closes #1902, #860, #837, and #1850 - moves all operators to a new heading - removes SQL syntax and combines it with the curl code samples - replaces amazon and imdb images for facets with meilisearch demo images - removes unused images in `.vuepress/public/faceted-search` - remove redundant code samples <hr> - Improve coherence between dataset and examples - A sample document was added as part of #2050 with `rating` and `director` fields - This PR uses `movie_ratings` instead of `movies` to clarify that this is a separate dataset - `faceted_search_facets_1` still uses `movies` as this code sample is used in the API reference as well Co-authored-by: Maryam Sulemani <[email protected]> Co-authored-by: Maryam <[email protected]> Co-authored-by: maryamsulemani97 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2035
Code samples are currently in code blocks to ease reviewing, but will be moved to
.code-samples.meilisearch.yamlandsample-template.yamlafter approval.