Skip to content

v1.1: Multi-index search #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 139 commits into from
Closed

v1.1: Multi-index search #2208

wants to merge 139 commits into from

Conversation

maryamsulemani97
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 commented Mar 9, 2023

closes #2199, #2200, and #2225

To avoid merge conflicts, I used one PR for all three related issues

This PR:

guimachiavelli and others added 4 commits March 6, 2023 16:07
2192: Remove pipeline list from language document r=maryamsulemani97 a=guimachiavelli

Closes #2184 

Co-authored-by: gui machiavelli <[email protected]>
guimachiavelli and others added 5 commits March 9, 2023 18:47
2217: Update license to 2023 r=maryamsulemani97 a=guimachiavelli

As title.

Co-authored-by: gui machiavelli <[email protected]>
2219: Fix link to product discussion in language.md r=maryamsulemani97 a=dichotommy

Label was changed. This PR replaces outdated link for tokenizer feedback with a working one.

Co-authored-by: Tommy <[email protected]>
@maryamsulemani97 maryamsulemani97 linked an issue Mar 14, 2023 that may be closed by this pull request
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review March 15, 2023 12:45
@maryamsulemani97 maryamsulemani97 requested a review from a team as a code owner March 15, 2023 12:45
Copy link
Member

@gmourier gmourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maryamsulemani97! I have just done a first round.

In reference/api the file multi_index.md should be called multi_search.md I think 💭

@Strift
Copy link
Contributor

Strift commented Mar 16, 2023

Moving my comment from Slack here. I wasn't able to find the link to the ecommerce demo in the source files. Is this the PR that should add it?

@maryamsulemani97
Copy link
Contributor Author

closing this for #2261

@guimachiavelli guimachiavelli deleted the multi_index branch April 13, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants