Skip to content

Add some missing build files #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add some missing build files #128

merged 1 commit into from
Oct 10, 2022

Conversation

bidoubiwa
Copy link
Contributor

Files of the latest PR #74 were not added in the lib files. Meaning that the changer are not applied on the npm package

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Oct 10, 2022
@bidoubiwa bidoubiwa requested a review from alallema October 10, 2022 14:37
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍖
I guess these files don't need to be reviewed since they are automatically generated yes?

@bidoubiwa
Copy link
Contributor Author

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 10, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit 13604cc into main Oct 10, 2022
@meili-bors meili-bors bot deleted the add_builded_files branch October 10, 2022 15:25
@bidoubiwa
Copy link
Contributor Author

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@bidoubiwa bidoubiwa added bug Something isn't working and removed skip-changelog The PR will not appear in the release changelogs labels Oct 11, 2022
@bidoubiwa bidoubiwa changed the title Update build files Add some missing build files Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants