Skip to content

Add new code-samples for matching_strategy #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2022
Merged

Add new code-samples for matching_strategy #215

merged 2 commits into from
Nov 1, 2022

Conversation

thicolares
Copy link
Contributor

@thicolares thicolares commented Oct 31, 2022 •
edited
Loading

Pull Request

Related issue

Fixes #210

What does this PR do?

  • Add new code-samples requested by the Meilisearch v0.29 release

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@brunoocasali brunoocasali added enhancement New feature or request documentation Improvements or additions to documentation hacktoberfest-accepted and removed enhancement New feature or request labels Oct 31, 2022
@brunoocasali
Copy link
Member

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

thicolares
thicolares commented Nov 1, 2022
View reviewed changes
.code-samples.meilisearch.yaml
search_parameter_guide_matching_strategy_1: |-
import 'package:meilisearch/src/matching_strategy_enum.dart';

await client.index('movies').search('big fat liar', matchingStrategy: MatchingStrategy.last);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the code samples to match the actual implementation that uses enum 😉

brunoocasali
brunoocasali approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🤘

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 1, 2022

Build succeeded:

@bors bors bot merged commit c3e2bbc into meilisearch:main Nov 1, 2022
@brunoocasali
Copy link
Member

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new code-samples requested by the Meilisearch v0.29 release
2 participants
@thicolares @brunoocasali