support _geoBoundingBox in filterExpression parameter
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
approved these changes
Apr 28, 2023
| @@ -76,6 +76,20 @@ class Meili { | |||
| distanceInMeters, | |||
| ); | |||
|
|
|||
| //TODO(ahmednfwela): rework this method after Dart 3 lands with patterns | |||
There was a problem hiding this comment.
If we adopt Dart 3, it will means that we will have to drop support for Dart 2, right?
There was a problem hiding this comment.
yes we will, but at the same time upgrading from dart 2 to dart 3 should be a no-cost operation, unless you are still using non null-safe code, which this package doesn't support anyway
There was a problem hiding this comment.
but we can leave that discussion until dart 3 lands, since only time will tell :)
brunoocasali
approved these changes
Apr 29, 2023
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Related to #267
What does this PR do?
_geoBoundingBoxinfilterExpressionPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
cc @brunoocasali